-
Notifications
You must be signed in to change notification settings - Fork 5
Feature/metrics/rich text links #787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps to identify broken links and generate reports on the internal and external links in platform rich texts.
Signed-off-by: Robert Smith <[email protected]>
Signed-off-by: Robert Smith <[email protected]>
- Implement RichTextLinkIdentifier service to extract and persist links from ActionText::RichText records. - Create ExternalLinkCheckerJob and InternalLinkCheckerJob for checking link validity. - Update Rake tasks for identifying and checking links. - Add specs for the new jobs and the RichTextLinkIdentifier service. - Include WebMock for stubbing HTTP requests in tests. - Add diagrams and documentation for the link checking process. - Introduce WebMock gem for stubbing external HTTP requests in specs.
…schema; include WebMock for testing
…g with associated views and specs
…ews, and associated migrations
…and maintainability
…to improve clarity and maintainability
…Link for model_class and improve model_collection query logic
… and ensure default values for link_type, position, and locale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive set of features for link checking and reporting within the BetterTogether metrics system. It adds new models, background jobs, controllers, and mailers to support automated link validation, reporting, and visualization. The changes are grouped into three main themes: link checking jobs, reporting and controller logic, and metrics visualization.
Link Checking Infrastructure:
ExternalLinkCheckerJob,InternalLinkCheckerJob), including queueing logic for distributing link checks across hosts and time windows to avoid overload (RichTextLinkCheckerQueueJoband its subclasses). [1] [2] [3] [4] [5]BetterTogether::Content::Linkmodel to persist discovered links and their metadata, and a namespace helper for links-related tables. [1] [2]Reporting and Controller Logic:
LinkCheckerReportsControllerto support creating, listing, and downloading link checker reports, including Turbo Stream support for dynamic updates.LinkCheckerReportSchedulerJob) and a mailer for delivering these reports. [1] [2]Metrics Visualization and Testing:
webmockgem for stubbing external HTTP requests in specs, improving test reliability.